Repository navigation
Treat approve-only members like guests when leaving and joining workspace rooms - #106929
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 265e59962d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-16.at.19.53.46.mov |
|
🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes leaving restricted rooms for approve-only members to match expected behavior, without adding a feature or making existing article instructions incorrect. |
Explanation of Change
Like Guest members, Approve-only members do not have room access (
Policy::FEATURE_ROOMS) on the workspace. When an Approve-only member leaves a restricted workspace room, the backend unshares the room from their account rather than keeping it shared with a hidden notification preference.Previously,
ReportDetailsMenuLeaveItemandcanJoinChatonly excludedCONST.POLICY.ROLE.GUEST. This change also treatsCONST.POLICY.ROLE.APPROVE_ONLYlikeGUESTwhen leaving and joining restricted workspace rooms, so leaving a room navigates away to Concierge / the most recent report and optimistically removes the room instead of keeping it open with a "Join" button.Fixed Issues
$ #106927
PROPOSAL:
Tests
Precondition:
Steps (as User B):
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari